docs: use the dynamic README header endpoint - #2266
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughREADME header images now use responsive ChangesREADME header images
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 34a86d0
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
- Coverage 90.35% 84.68% -5.67%
==========================================
Files 38 45 +7
Lines 1752 960 -792
Branches 444 96 -348
==========================================
- Hits 1583 813 -770
+ Misses 149 129 -20
+ Partials 20 18 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* docs: use the dynamic README header endpoint (#2266) * docs: fix sidebar 404s and validate config.json nav targets (#2278) * docs(config): remove nav entries pointing at non-existent reference pages Six sidebar entries in docs/config.json referenced reference pages that do not exist, so each rendered as a 404. FieldMeta, FieldState and FieldInfo lost their generated pages in 6a73479 without config.json being updated to match. useTransform is not exported from @tanstack/react-form, and vue/solid never had UseField/CreateField types. Repoint the FieldMeta entry to AnyFieldMeta, the surviving public field-metadata type, and drop the rest. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017z89Nb8dzFPu7VnsvN2VA9 * chore(scripts): verify docs/config.json nav targets in verify-links verify-links only extracted links written inside .md files, so sidebar entries in docs/config.json were never checked and could point at pages that no longer exist without failing CI. Walk every `to` in the nav config and resolve it the same way markdown links are resolved, including the framework examples directory mapping. Failures report the nav breadcrumb so the offending entry is easy to locate. The shared resolution logic is extracted into resolveDocTarget so the two checks cannot drift apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017z89Nb8dzFPu7VnsvN2VA9 * fix(scripts): fail verify-links when the check itself throws The rejection handler only logged, so Node still exited 0. Reading or parsing docs/config.json can now throw, which meant test:docs could pass while the navigation check never ran. Confirmed by pointing the script at malformed and missing config files: both exited 0 before this change and exit 1 after. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017z89Nb8dzFPu7VnsvN2VA9 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> # Conflicts: # docs/config.json --------- Co-authored-by: Irfan fandi <irfanfandi38@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adopts the dynamic README header endpoint added in TanStack/tanstack.com#1076,
which is merged and live.
Every README banner in this repo now points a
<picture>athttps://tanstack.com/api/readme/instead of a committed PNG. The endpointrenders 1800x450 in light and dark, so a branding change lands in every README
at once and dark-mode readers get a dark banner.
What changed
<picture>, per GitHub's guidance. The trailing<img>stays the light variant, as the fallback for renderers that ignore<picture>(npm, most editors).?framework=so each banner shows its own package name instead of the generic library name.media/header_form.png.The package READMEs were pointing at
media/repo-header.png, the GitHub social-preview image. That file stays where it is - only the README references change.Verification
Every generated URL in this diff was requested against the live endpoint and
returned
200 image/pngat 1800x450.git grepconfirms no README stillreferences the old
media/header_*.pngpath.Heads up: deleting the committed PNG means npm pages for already-published
versions that embed the
github.com/ghraw/.../main/media/header_*.pnglink will show a broken image, since that link is branch-pinned. New releases
pick up the endpoint URL.
Summary by CodeRabbit